Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit e8b58d6d authored by Peter Rosin's avatar Peter Rosin Committed by Heiko Stuebner
Browse files

drm/rockchip: lvds: avoid duplicating drm_bridge_attach 



drm_bridge_attach takes care of these assignments, so there is no need
to open-code them a second time.

Signed-off-by: default avatarPeter Rosin <peda@axentia.se>
Signed-off-by: default avatarHeiko Stuebner <heiko@sntech.de>
Link: https://patchwork.freedesktop.org/patch/msgid/20180502074025.12421-3-peda@axentia.se
parent 957428f9

drivers/gpu/drm/rockchip/rockchip_lvds.c

+0 −2
Original line number Original line Diff line number Diff line
@@ -446,14 +446,12 @@ static int rockchip_lvds_bind(struct device *dev, struct device *master, 
			goto err_free_connector;

			goto err_free_connector;

		}

		}

	} else {

	} else {

		lvds->bridge->encoder = encoder;

		ret = drm_bridge_attach(encoder, lvds->bridge, NULL);

		ret = drm_bridge_attach(encoder, lvds->bridge, NULL);

		if (ret) {

		if (ret) {

			DRM_DEV_ERROR(drm_dev->dev,

			DRM_DEV_ERROR(drm_dev->dev,

				      "failed to attach bridge: %d\n", ret);

				      "failed to attach bridge: %d\n", ret);

			goto err_free_encoder;

			goto err_free_encoder;

		}

		}

		encoder->bridge = lvds->bridge;

	}

	}





	pm_runtime_enable(dev);

	pm_runtime_enable(dev);