Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit e8ad3b1a authored by Markus Pargmann's avatar Markus Pargmann Committed by Antonio Quartulli
Browse files

batman-adv: main, Convert is_my_mac() to bool 



It is much clearer to see a bool type as return value than 'int' for
functions that are supposed to return true or false.

Signed-off-by: default avatarMarkus Pargmann <mpa@pengutronix.de>
Signed-off-by: default avatarMarek Lindner <mareklindner@neomailbox.ch>
parent a0c77227

net/batman-adv/main.c

+7 −4
Original line number Diff line number Diff line
@@ -209,10 +209,13 @@ void batadv_mesh_free(struct net_device *soft_iface) 
 * interfaces in the current mesh

 * @bat_priv: the bat priv with all the soft interface information

 * @addr: the address to check

 *

 * Returns 'true' if the mac address was found, false otherwise.

 */

int batadv_is_my_mac(struct batadv_priv *bat_priv, const uint8_t *addr)

bool batadv_is_my_mac(struct batadv_priv *bat_priv, const uint8_t *addr)

{

	const struct batadv_hard_iface *hard_iface;

	bool is_my_mac = false;



	rcu_read_lock();

	list_for_each_entry_rcu(hard_iface, &batadv_hardif_list, list) {
@@ -223,12 +226,12 @@ int batadv_is_my_mac(struct batadv_priv *bat_priv, const uint8_t *addr) 
			continue;



		if (batadv_compare_eth(hard_iface->net_dev->dev_addr, addr)) {

			rcu_read_unlock();

			return 1;

			is_my_mac = true;

			break;

		}

	}

	rcu_read_unlock();

	return 0;

	return is_my_mac;

}



/**

net/batman-adv/main.h

+1 −1
Original line number Diff line number Diff line
@@ -195,7 +195,7 @@ extern struct workqueue_struct *batadv_event_workqueue; 


int batadv_mesh_init(struct net_device *soft_iface);

void batadv_mesh_free(struct net_device *soft_iface);

int batadv_is_my_mac(struct batadv_priv *bat_priv, const uint8_t *addr);

bool batadv_is_my_mac(struct batadv_priv *bat_priv, const uint8_t *addr);

struct batadv_hard_iface *

batadv_seq_print_text_primary_if_get(struct seq_file *seq);

int batadv_max_header_len(void);