Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit e8904dc5 authored by Jesper Juhl's avatar Jesper Juhl Committed by Nicholas Bellinger
Browse files

iscsi-target: Fix up a few assignments 



A statement such as
  struct iscsi_node_attrib *na = na = iscsit_tpg_get_node_attrib(sess);
has undefined behaviour since there are two assignments to 'na', strictly
speaking (the order in which side-effects from the assignments take place
is undefined since there's no intervening sequence point), and it looks
unintentional in any case.

Signed-off-by: default avatarJesper Juhl <jj@chaosbits.net>
Signed-off-by: default avatarNicholas Bellinger <nab@linux-iscsi.org>
parent f8d48ae5

drivers/target/iscsi/iscsi_target_erl1.c

+2 −2
Original line number Diff line number Diff line
@@ -1238,7 +1238,7 @@ void iscsit_mod_dataout_timer(struct iscsi_cmd *cmd) 
{

	struct iscsi_conn *conn = cmd->conn;

	struct iscsi_session *sess = conn->sess;

	struct iscsi_node_attrib *na = na = iscsit_tpg_get_node_attrib(sess);

	struct iscsi_node_attrib *na = iscsit_tpg_get_node_attrib(sess);



	spin_lock_bh(&cmd->dataout_timeout_lock);

	if (!(cmd->dataout_timer_flags & ISCSI_TF_RUNNING)) {
@@ -1261,7 +1261,7 @@ void iscsit_start_dataout_timer( 
	struct iscsi_conn *conn)

{

	struct iscsi_session *sess = conn->sess;

	struct iscsi_node_attrib *na = na = iscsit_tpg_get_node_attrib(sess);

	struct iscsi_node_attrib *na = iscsit_tpg_get_node_attrib(sess);



	if (cmd->dataout_timer_flags & ISCSI_TF_RUNNING)

		return;