Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit e8820646 authored by Arnd Bergmann's avatar Arnd Bergmann Committed by Alex Deucher
Browse files

drm/radeon: properly initialize r600_audio_status() data 



The structure returned from r600_audio_status() is only partially
initialized, and older gcc versions (4.3 and 4.4) warn about this:

drivers/gpu/drm/radeon/r600_hdmi.c: In function 'r600_audio_status':
drivers/gpu/drm/radeon/r600_hdmi.c:108: error: 'status.id' is used uninitialized in this function
drivers/gpu/drm/radeon/r600_hdmi.c:108: error: 'status.connected' is used uninitialized in this function
drivers/gpu/drm/radeon/r600_hdmi.c:108: error: 'status.offset' is used uninitialized in this function

This is harmless and surprisingly correct in C99, as the caller
only accesses the fields that got initialized, so newer compilers
don't warn about it, but initializing the entire structure feels
like the right thing to do here and avoids the warning.

Reviewed-by: default avatarChristian König <christian.koenig@amd.com>
Signed-off-by: default avatarArnd Bergmann <arnd@arndb.de>
Signed-off-by: default avatarAlex Deucher <alexander.deucher@amd.com>
parent cf661ec1

drivers/gpu/drm/radeon/r600_hdmi.c

+1 −1
Original line number Diff line number Diff line
@@ -58,7 +58,7 @@ enum r600_hdmi_iec_status_bits { 


static struct r600_audio_pin r600_audio_status(struct radeon_device *rdev)

{

	struct r600_audio_pin status;

	struct r600_audio_pin status = {};

	uint32_t value;



	value = RREG32(R600_AUDIO_RATE_BPS_CHANNEL);