Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit e842b068 authored by Dan Carpenter's avatar Dan Carpenter Committed by David S. Miller
Browse files

qlcnic: dcb: a couple off by one bugs 



The ->tc_cfg[] array has QLC_DCB_MAX_TC (8) elements so the check is
off by one.  These functions are always called with valid values though
so it doesn't affect how the code works.

Signed-off-by: default avatarDan Carpenter <dan.carpenter@oracle.com>
Acked-by: default avatarSucheta Chakraborty <sucheta.chakraborty@qlogic.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent c84a5711

drivers/net/ethernet/qlogic/qlcnic/qlcnic_dcb.c

+2 −2
Original line number Diff line number Diff line
@@ -807,7 +807,7 @@ qlcnic_dcb_get_pg_tc_cfg_tx(struct net_device *netdev, int tc, u8 *prio, 
	    !type->tc_param_valid)

		return;



	if (tc < 0 || (tc > QLC_DCB_MAX_TC))

	if (tc < 0 || (tc >= QLC_DCB_MAX_TC))

		return;



	tc_cfg = &type->tc_cfg[tc];
@@ -843,7 +843,7 @@ static void qlcnic_dcb_get_pg_bwg_cfg_tx(struct net_device *netdev, int pgid, 
	    !type->tc_param_valid)

		return;



	if (pgid < 0 || pgid > QLC_DCB_MAX_PG)

	if (pgid < 0 || pgid >= QLC_DCB_MAX_PG)

		return;



	pgcfg = &type->pg_cfg[pgid];