Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit e827756d authored by Oza Pawandeep's avatar Oza Pawandeep Committed by Greg Kroah-Hartman
Browse files

nvmem: correct Broadcom OTP controller driver writes 



- use data write offset to write otp data instead of read offset
- use OTP program command 0x8 to write otp with ECC rather than just
command 0xA without ECC

Fixes: 9d59c6e8 ("nvmem: Add the Broadcom OTP controller driver")
Signed-off-by: default avatarOza Pawandeep <oza.oza@broadcom.com>
Signed-off-by: default avatarScott Branden <scott.branden@broadcom.com>
Signed-off-by: default avatarSrinivas Kandagatla <srinivas.kandagatla@linaro.org>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent de0d6dbd

drivers/nvmem/bcm-ocotp.c

+2 −2
Original line number Diff line number Diff line
@@ -34,7 +34,7 @@ 
#define OTPC_CMD_READ                0x0

#define OTPC_CMD_OTP_PROG_ENABLE     0x2

#define OTPC_CMD_OTP_PROG_DISABLE    0x3

#define OTPC_CMD_PROGRAM             0xA

#define OTPC_CMD_PROGRAM             0x8



/* OTPC Status Bits */

#define OTPC_STAT_CMD_DONE           BIT(1)
@@ -209,7 +209,7 @@ static int bcm_otpc_write(void *context, unsigned int offset, void *val, 
		set_command(priv->base, OTPC_CMD_PROGRAM);

		set_cpu_address(priv->base, address++);

		for (i = 0; i < priv->map->otpc_row_size; i++) {

			writel(*buf, priv->base + priv->map->data_r_offset[i]);

			writel(*buf, priv->base + priv->map->data_w_offset[i]);

			buf++;

			bytes_written += sizeof(*buf);

		}