Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit e795556a authored by Joe Perches's avatar Joe Perches Committed by Linus Torvalds
Browse files

checkpatch: improve MULTISTATEMENT_MACRO_USE_DO_WHILE test 

The logic currrently misses macros that start with an if statement.

e.g.:    #define foo(bar)   if (bar) baz;

Add a test for macro content that starts with if

Link: http://lkml.kernel.org/r/a9d41aafe1673889caf1a9850208fb7fd74107a0.1491783914.git.joe@perches.com


Signed-off-by: default avatarJoe Perches <joe@perches.com>
Reported-by: default avatarAndreas Mohr <andi@lisas.de>
Original-patch-by: default avatarAlfonso Lima <alfonsolimaastor@gmail.com>
Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
parent d9190e4e

scripts/checkpatch.pl

+4 −2
Original line number Diff line number Diff line
@@ -4849,8 +4849,10 @@ sub process { 
			    $dstat !~ /^\(\{/ &&						# ({...

			    $ctx !~ /^.\s*#\s*define\s+TRACE_(?:SYSTEM|INCLUDE_FILE|INCLUDE_PATH)\b/)

			{



				if ($dstat =~ /;/) {

				if ($dstat =~ /^\s*if\b/) {

					ERROR("MULTISTATEMENT_MACRO_USE_DO_WHILE",

					      "Macros starting with if should be enclosed by a do - while loop to avoid possible if/else logic defects\n" . "$herectx");

				} elsif ($dstat =~ /;/) {

					ERROR("MULTISTATEMENT_MACRO_USE_DO_WHILE",

					      "Macros with multiple statements should be enclosed in a do - while loop\n" . "$herectx");

				} else {