Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit e7783ba3 authored by Imre Deak's avatar Imre Deak Committed by Inki Dae
Browse files

drm: hold event_lock while accessing vblank_event_list 



Currently the only users of drm_vblank_off() are i915 and gma500,
neither of which holds the event_lock when calling this function.
Fix this by holding the event_lock while traversing the list.

Signed-off-by: default avatarImre Deak <imre.deak@intel.com>
Signed-off-by: default avatarInki Dae <inki.dae@samsung.com>
Signed-off-by: default avatarKyungmin Park <kyungmin.park@samsung.com>
parent 9fb7dff5

drivers/gpu/drm/drm_irq.c

+3 −0
Original line number Diff line number Diff line
@@ -1021,6 +1021,8 @@ void drm_vblank_off(struct drm_device *dev, int crtc) 


	/* Send any queued vblank events, lest the natives grow disquiet */

	seq = drm_vblank_count_and_time(dev, crtc, &now);



	spin_lock(&dev->event_lock);

	list_for_each_entry_safe(e, t, &dev->vblank_event_list, base.link) {

		if (e->pipe != crtc)

			continue;
@@ -1031,6 +1033,7 @@ void drm_vblank_off(struct drm_device *dev, int crtc) 
		drm_vblank_put(dev, e->pipe);

		send_vblank_event(dev, e, seq, &now);

	}

	spin_unlock(&dev->event_lock);



	spin_unlock_irqrestore(&dev->vbl_lock, irqflags);

}