Commit e729b503 authored Mar 04, 2016 by Lars-Peter Clausen Committed by Martin K. Petersen Mar 07, 2016

be2iscsi: Remove unnecessary synchronize_irq() before free_irq()



Calling synchronize_irq() right before free_irq() is quite useless. On one
hand the IRQ can easily fire again before free_irq() is entered, on the
other hand free_irq() itself calls synchronize_irq() internally (in a race
condition free way), before any state associated with the IRQ is freed.

Patch was generated using the following semantic patch:
// <smpl>
@@
expression irq;
@@
-synchronize_irq(irq);
 free_irq(irq, ...);
// </smpl>

Signed-off-by: Lars-Peter Clausen <lars@metafoo.de>
Reviewed-by: Jitendra Bhivare <jitendra.bhivare@broadcom.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>

parent 4cd2459c

drivers/scsi/be2iscsi/be_main.c

+1 −4

Original line number	Diff line number	Diff line
		@@ -5303,15 +5303,12 @@ static void beiscsi_quiesce(struct beiscsi_hba *phba,
		if (phba->msix_enabled) {
		for (i = 0; i <= phba->num_cpus; i++) {
		msix_vec = phba->msix_entries[i].vector;
		synchronize_irq(msix_vec);
		free_irq(msix_vec, &phwi_context->be_eq[i]);
		kfree(phba->msi_name[i]);
		}
		} else
		if (phba->pcidev->irq) {
		synchronize_irq(phba->pcidev->irq);
		if (phba->pcidev->irq)
		free_irq(phba->pcidev->irq, phba);
		}
		pci_disable_msix(phba->pcidev);
		cancel_delayed_work_sync(&phba->beiscsi_hw_check_task);