Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit e722af63 authored by Nathan Fontenot's avatar Nathan Fontenot Committed by David S. Miller
Browse files

ibmvnic: Call napi_disable instead of napi_enable in failure path 



The failure path in ibmvnic_open() mistakenly makes a second call
to napi_enable instead of calling napi_disable. This can result
in a BUG_ON for any queues that were enabled in the previous call
to napi_enable.

Signed-off-by: default avatarNathan Fontenot <nfont@linux.vnet.ibm.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent db5d0b59

drivers/net/ethernet/ibm/ibmvnic.c

+1 −1
Original line number Diff line number Diff line
@@ -506,7 +506,7 @@ static int ibmvnic_open(struct net_device *netdev) 
	adapter->rx_pool = NULL;

rx_pool_arr_alloc_failed:

	for (i = 0; i < adapter->req_rx_queues; i++)

		napi_enable(&adapter->napi[i]);

		napi_disable(&adapter->napi[i]);

alloc_napi_failed:

	return -ENOMEM;

}