Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit e6ae9195 authored by Wei Yongjun's avatar Wei Yongjun Committed by Linus Walleij
Browse files

gpio: sodaville: fix some error return code on error path 



Fix to return a negative error code from the error handling
case instead of 0.

Signed-off-by: default avatarWei Yongjun <yongjun_wei@trendmicro.com.cn>
Signed-off-by: default avatarLinus Walleij <linus.walleij@linaro.org>
parent ca0ae81d

drivers/gpio/gpio-sodaville.c

+6 −2
Original line number Diff line number Diff line
@@ -176,8 +176,10 @@ static int sdv_register_irqsupport(struct sdv_gpio_chip_data *sd, 


	sd->id = irq_domain_add_legacy(pdev->dev.of_node, SDV_NUM_PUB_GPIOS,

				sd->irq_base, 0, &irq_domain_sdv_ops, sd);

	if (!sd->id)

	if (!sd->id) {

		ret = -ENODEV;

		goto out_free_irq;

	}

	return 0;

out_free_irq:

	free_irq(pdev->irq, sd);
@@ -212,8 +214,10 @@ static int sdv_gpio_probe(struct pci_dev *pdev, 
	}



	addr = pci_resource_start(pdev, GPIO_BAR);

	if (!addr)

	if (!addr) {

		ret = -ENODEV;

		goto release_reg;

	}

	sd->gpio_pub_base = ioremap(addr, pci_resource_len(pdev, GPIO_BAR));



	prop = of_get_property(pdev->dev.of_node, "intel,muxctl", &len);