Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit e655bc35 authored by Chris Wilson's avatar Chris Wilson
Browse files

drm/i915: Remove i915_gem_execbuffer_retire_commands() 



Move the single line to the callsite as the name is now misleading, and
the purpose is solely to add the request to the execution queue. Here,
we can see that if we failed to dispatch the batch from the request, we
can forgo flushing the GPU when closing the request.

Signed-off-by: default avatarChris Wilson <chris@chris-wilson.co.uk>
Reviewed-by: default avatarJoonas Lahtinen <joonas.lahtinen@linux.intel.com>
Link: http://patchwork.freedesktop.org/patch/msgid/1470324762-2545-5-git-send-email-chris@chris-wilson.co.uk
parent 0340d9fd

drivers/gpu/drm/i915/i915_gem_execbuffer.c

+1 −8
Original line number Original line Diff line number Diff line
@@ -1211,13 +1211,6 @@ i915_gem_execbuffer_move_to_active(struct list_head *vmas, 
	}

	}

}

}





static void

i915_gem_execbuffer_retire_commands(struct i915_execbuffer_params *params)

{

	/* Add a breadcrumb for the completion of the batch buffer */

	__i915_add_request(params->request, params->batch_obj, true);

}



static int

static int

i915_reset_gen7_sol_offsets(struct drm_i915_gem_request *req)

i915_reset_gen7_sol_offsets(struct drm_i915_gem_request *req)

{

{
@@ -1692,7 +1685,7 @@ i915_gem_do_execbuffer(struct drm_device *dev, void *data, 




	ret = execbuf_submit(params, args, &eb->vmas);

	ret = execbuf_submit(params, args, &eb->vmas);

err_request:

err_request:

	i915_gem_execbuffer_retire_commands(params);

	__i915_add_request(params->request, params->batch_obj, ret == 0);





err_batch_unpin:

err_batch_unpin:

	/*

	/*