Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit e61cb0d5 authored by Jan Beulich's avatar Jan Beulich Committed by Chris Wilson
Browse files

some clean up to intel-gtt.c 



In commit e517a5e9 the call to
map_page_into_agp() got removed from intel_i830_setup_flush(), but the
counterpart call from intel_i830_fini_flush() to unmap_page_from_agp()
was left in place.

Additionally, the page allocated here never gets its physical address
used for sending to hardware, so there's no need to allocate it with
GFP_DMA32. Nor is __GFP_ZERO really necessary, as the page is used
only to store data to force flushing of some internal processor state.

Signed-off-by: default avatarJan Beulich <jbeulich@novell.com>
Cc: Eric Anholt <eric@anholt.net>
Signed-off-by: default avatarChris Wilson <chris@chris-wilson.co.uk>
parent 5ceb0f9b

drivers/char/agp/intel-gtt.c

+1 −2
Original line number Diff line number Diff line
@@ -814,7 +814,6 @@ static void i830_cleanup(void) 
{

	kunmap(intel_private.i8xx_page);

	intel_private.i8xx_flush_page = NULL;

	unmap_page_from_agp(intel_private.i8xx_page);



	__free_page(intel_private.i8xx_page);

	intel_private.i8xx_page = NULL;
@@ -826,7 +825,7 @@ static void intel_i830_setup_flush(void) 
	if (intel_private.i8xx_page)

		return;



	intel_private.i8xx_page = alloc_page(GFP_KERNEL | __GFP_ZERO | GFP_DMA32);

	intel_private.i8xx_page = alloc_page(GFP_KERNEL);

	if (!intel_private.i8xx_page)

		return;