Commit e5ebe632 authored Dec 11, 2015 by Ursula Braun Committed by David S. Miller Dec 14, 2015

qeth: initialize net_device with carrier off



/sys/class/net/<interface>/operstate for an active qeth network
interface offen shows "unknown", which translates to "state UNKNOWN
in output of "ip link show". It is caused by a missing initialization
of the __LINK_STATE_NOCARRIER bit in the net_device state field.
This patch adds a netif_carrier_off() invocation when creating the
net_device for a qeth device.

Signed-off-by: Ursula Braun <ubraun@linux.vnet.ibm.com>
Acked-by: Hendrik Brueckner <brueckner@linux.vnet.ibm.com>
Reference-ID: Bugzilla 133209
Signed-off-by: David S. Miller <davem@davemloft.net>

parent b475e316

drivers/s390/net/qeth_l2_main.c

+1 −0

Original line number	Diff line number	Diff line
		@@ -1126,6 +1126,7 @@ static int qeth_l2_setup_netdev(struct qeth_card *card)
		qeth_l2_request_initial_mac(card);
		SET_NETDEV_DEV(card->dev, &card->gdev->dev);
		netif_napi_add(card->dev, &card->napi, qeth_l2_poll, QETH_NAPI_WEIGHT);
		netif_carrier_off(card->dev);
		return register_netdev(card->dev);
		}

drivers/s390/net/qeth_l3_main.c

+1 −0

Original line number	Diff line number	Diff line
		@@ -3199,6 +3199,7 @@ static int qeth_l3_setup_netdev(struct qeth_card *card)

		SET_NETDEV_DEV(card->dev, &card->gdev->dev);
		netif_napi_add(card->dev, &card->napi, qeth_l3_poll, QETH_NAPI_WEIGHT);
		netif_carrier_off(card->dev);
		return register_netdev(card->dev);
		}