Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit e5b20d0b authored by Wolfram Sang's avatar Wolfram Sang Committed by Greg Kroah-Hartman
Browse files

drm: encoder_slave: fix refcouting error for modules 



[ Upstream commit f78d4032de60f50fd4afaa0fb68ea03b985f820a ]

module_put() balances try_module_get(), not request_module(). Fix the
error path to match that.

Fixes: 2066facc ("drm/kms: slave encoder interface.")
Signed-off-by: default avatarWolfram Sang <wsa+renesas@sang-engineering.com>
Reviewed-by: default avatarEmil Velikov <emil.l.velikov@gmail.com>
Acked-by: default avatarDaniel Vetter <daniel.vetter@ffwll.ch>
Signed-off-by: default avatarWolfram Sang <wsa@kernel.org>
Signed-off-by: default avatarSasha Levin <sashal@kernel.org>
parent edcb7efd

drivers/gpu/drm/drm_encoder_slave.c

+3 −2
Original line number Diff line number Diff line
@@ -84,7 +84,7 @@ int drm_i2c_encoder_init(struct drm_device *dev, 


	err = encoder_drv->encoder_init(client, dev, encoder);

	if (err)

		goto fail_unregister;

		goto fail_module_put;



	if (info->platform_data)

		encoder->slave_funcs->set_config(&encoder->base,
@@ -92,9 +92,10 @@ int drm_i2c_encoder_init(struct drm_device *dev, 


	return 0;



fail_module_put:

	module_put(module);

fail_unregister:

	i2c_unregister_device(client);

	module_put(module);

fail:

	return err;

}