Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit e59d16c0 authored by Vladimir Kondratiev's avatar Vladimir Kondratiev Committed by Kalle Valo
Browse files

wil6210: avoid Tx descriptor double write 



Non-cacheable Tx descriptor for the last fragment of
multi-fragment frame used to be written back twice.

Refactor code to always write non-cacheable descriptor
only once

Signed-off-by: default avatarVladimir Kondratiev <qca_vkondrat@qca.qualcomm.com>
Signed-off-by: default avatarKalle Valo <kvalo@codeaurora.org>
parent a3c74902

drivers/net/wireless/ath/wil6210/txrx.c

+1 −3
Original line number Diff line number Diff line
@@ -981,8 +981,6 @@ static int wil_tx_vring(struct wil6210_priv *wil, struct vring *vring, 


	vring->ctx[i].nr_frags = nr_frags;

	wil_tx_desc_set_nr_frags(d, nr_frags);

	if (nr_frags)

		*_d = *d;



	/* middle segments */

	for (; f < nr_frags; f++) {
@@ -990,6 +988,7 @@ static int wil_tx_vring(struct wil6210_priv *wil, struct vring *vring, 
				&skb_shinfo(skb)->frags[f];

		int len = skb_frag_size(frag);



		*_d = *d;

		i = (swhead + f + 1) % vring->size;

		_d = &vring->va[i].tx;

		pa = skb_frag_dma_map(dev, frag, 0, skb_frag_size(frag),
@@ -1003,7 +1002,6 @@ static int wil_tx_vring(struct wil6210_priv *wil, struct vring *vring, 
		 * it will succeed here too

		 */

		wil_tx_desc_offload_cksum_set(wil, d, skb);

		*_d = *d;

	}

	/* for the last seg only */

	d->dma.d0 |= BIT(DMA_CFG_DESC_TX_0_CMD_EOP_POS);