Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit e50944e2 authored by Eric Biggers's avatar Eric Biggers Committed by Herbert Xu
Browse files

crypto: shash - remove useless setting of type flags 



Many shash algorithms set .cra_flags = CRYPTO_ALG_TYPE_SHASH.  But this
is redundant with the C structure type ('struct shash_alg'), and
crypto_register_shash() already sets the type flag automatically,
clearing any type flag that was already there.  Apparently the useless
assignment has just been copy+pasted around.

So, remove the useless assignment from all the shash algorithms.

This patch shouldn't change any actual behavior.

Signed-off-by: default avatarEric Biggers <ebiggers@google.com>
Signed-off-by: default avatarHerbert Xu <herbert@gondor.apana.org.au>
parent 8aeef492

arch/arm/crypto/ghash-ce-glue.c

+1 −1
Original line number Diff line number Diff line
@@ -152,7 +152,7 @@ static struct shash_alg ghash_alg = { 
		.cra_name	= "__ghash",

		.cra_driver_name = "__driver-ghash-ce",

		.cra_priority	= 0,

		.cra_flags	= CRYPTO_ALG_TYPE_SHASH | CRYPTO_ALG_INTERNAL,

		.cra_flags	= CRYPTO_ALG_INTERNAL,

		.cra_blocksize	= GHASH_BLOCK_SIZE,

		.cra_ctxsize	= sizeof(struct ghash_key),

		.cra_module	= THIS_MODULE,

arch/arm/crypto/sha1-ce-glue.c

+0 −1
Original line number Diff line number Diff line
@@ -75,7 +75,6 @@ static struct shash_alg alg = { 
		.cra_name		= "sha1",

		.cra_driver_name	= "sha1-ce",

		.cra_priority		= 200,

		.cra_flags		= CRYPTO_ALG_TYPE_SHASH,

		.cra_blocksize		= SHA1_BLOCK_SIZE,

		.cra_module		= THIS_MODULE,

	}

arch/arm/crypto/sha1_glue.c

+0 −1
Original line number Diff line number Diff line
@@ -67,7 +67,6 @@ static struct shash_alg alg = { 
		.cra_name	=	"sha1",

		.cra_driver_name=	"sha1-asm",

		.cra_priority	=	150,

		.cra_flags	=	CRYPTO_ALG_TYPE_SHASH,

		.cra_blocksize	=	SHA1_BLOCK_SIZE,

		.cra_module	=	THIS_MODULE,

	}

arch/arm/crypto/sha1_neon_glue.c

+0 −1
Original line number Diff line number Diff line
@@ -83,7 +83,6 @@ static struct shash_alg alg = { 
		.cra_name		= "sha1",

		.cra_driver_name	= "sha1-neon",

		.cra_priority		= 250,

		.cra_flags		= CRYPTO_ALG_TYPE_SHASH,

		.cra_blocksize		= SHA1_BLOCK_SIZE,

		.cra_module		= THIS_MODULE,

	}

arch/arm/crypto/sha2-ce-glue.c

+0 −2
Original line number Diff line number Diff line
@@ -78,7 +78,6 @@ static struct shash_alg algs[] = { { 
		.cra_name		= "sha224",

		.cra_driver_name	= "sha224-ce",

		.cra_priority		= 300,

		.cra_flags		= CRYPTO_ALG_TYPE_SHASH,

		.cra_blocksize		= SHA256_BLOCK_SIZE,

		.cra_module		= THIS_MODULE,

	}
@@ -93,7 +92,6 @@ static struct shash_alg algs[] = { { 
		.cra_name		= "sha256",

		.cra_driver_name	= "sha256-ce",

		.cra_priority		= 300,

		.cra_flags		= CRYPTO_ALG_TYPE_SHASH,

		.cra_blocksize		= SHA256_BLOCK_SIZE,

		.cra_module		= THIS_MODULE,

	}