Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit e4c5babd authored by Joe Perches's avatar Joe Perches Committed by Linus Torvalds
Browse files

checkpatch: notice unbalanced else braces in a patch 

Patches that add or modify code like

	} else
		<foo>
or
	else {
		<bar>

where one branch appears to have a brace and the other branch does not
have a brace should emit a --strict style message.

Link: http://lkml.kernel.org/r/c6be32747fc725cbc235802991746700a0f54fdc.1486754390.git.joe@perches.com


Signed-off-by: default avatarJoe Perches <joe@perches.com>
Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
parent 1bde561e

scripts/checkpatch.pl

+6 −0
Original line number Diff line number Diff line
@@ -5104,6 +5104,12 @@ sub process { 
			}

		}



# check for single line unbalanced braces

		if ($sline =~ /.\s*\}\s*else\s*$/ ||

		    $sline =~ /.\s*else\s*\{\s*$/) {

			CHK("BRACES", "Unbalanced braces around else statement\n" . $herecurr);

		}



# check for unnecessary blank lines around braces

		if (($line =~ /^.\s*}\s*$/ && $prevrawline =~ /^.\s*$/)) {

			if (CHK("BRACES",