Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit e4c36076 authored by Johan Hovold's avatar Johan Hovold Committed by Greg Kroah-Hartman
Browse files

USB: cdc-acm: fix I/O after failed open 



Make sure to kill any already submitted read urbs on read-urb submission
failures in open in order to prevent doing I/O for a closed port.

Fixes: 088c64f8 ("USB: cdc-acm: re-write read processing")
Signed-off-by: default avatarJohan Hovold <jhovold@gmail.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 8727bf68

drivers/usb/class/cdc-acm.c

+3 −0
Original line number Diff line number Diff line
@@ -506,6 +506,7 @@ static int acm_port_activate(struct tty_port *port, struct tty_struct *tty) 
{

	struct acm *acm = container_of(port, struct acm, port);

	int retval = -ENODEV;

	int i;



	dev_dbg(&acm->control->dev, "%s\n", __func__);
@@ -556,6 +557,8 @@ static int acm_port_activate(struct tty_port *port, struct tty_struct *tty) 
	return 0;



error_submit_read_urbs:

	for (i = 0; i < acm->rx_buflimit; i++)

		usb_kill_urb(acm->read_urbs[i]);

	acm->ctrlout = 0;

	acm_set_control(acm, acm->ctrlout);

error_set_control: