Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit e3eb270f authored by Malcolm Priestley's avatar Malcolm Priestley Committed by Greg Kroah-Hartman
Browse files

staging: vt6656: [BUG] main_usb.c oops on device_close move flag earlier. 



The vt6656 is prone to resetting on the usb bus.

It seems there is a race condition and wpa supplicant is
trying to open the device via iw_handlers before its actually
closed at a stage that the buffers are being removed.

The device is longer considered open when the
buffers are being removed. So move ~DEVICE_FLAGS_OPENED
flag to before freeing the device buffers.

Signed-off-by: default avatarMalcolm Priestley <tvboxspy@gmail.com>
Cc: stable@vger.kernel.org
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 18e35e08

drivers/staging/vt6656/main_usb.c

+2 −1
Original line number Diff line number Diff line
@@ -1098,6 +1098,8 @@ static int device_close(struct net_device *dev) 
    memset(pMgmt->abyCurrBSSID, 0, 6);

    pMgmt->eCurrState = WMAC_STATE_IDLE;



	pDevice->flags &= ~DEVICE_FLAGS_OPENED;



    device_free_tx_bufs(pDevice);

    device_free_rx_bufs(pDevice);

    device_free_int_bufs(pDevice);
@@ -1109,7 +1111,6 @@ static int device_close(struct net_device *dev) 
    usb_free_urb(pDevice->pInterruptURB);



    BSSvClearNodeDBTable(pDevice, 0);

    pDevice->flags &=(~DEVICE_FLAGS_OPENED);



    DBG_PRT(MSG_LEVEL_DEBUG, KERN_INFO "device_close2 \n");