Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit e36fef66 authored by Zhu Yanjun's avatar Zhu Yanjun Committed by David S. Miller
Browse files

mlx4_en: remove unnecessary returned value check 



The function __mlx4_zone_remove_one_entry always returns zero. So
it is not necessary to check it.

Cc: Joe Jin <joe.jin@oracle.com>
Cc: Junxiao Bi <junxiao.bi@oracle.com>
Signed-off-by: default avatarZhu Yanjun <yanjun.zhu@oracle.com>
Reviewed-by: default avatarYuval Shaia <yuval.shaia@oracle.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent dfcc16c9

drivers/net/ethernet/mellanox/mlx4/alloc.c

+3 −5
Original line number Diff line number Diff line
@@ -283,7 +283,7 @@ int mlx4_zone_add_one(struct mlx4_zone_allocator *zone_alloc, 
}



/* Should be called under a lock */

static int __mlx4_zone_remove_one_entry(struct mlx4_zone_entry *entry)

static void __mlx4_zone_remove_one_entry(struct mlx4_zone_entry *entry)

{

	struct mlx4_zone_allocator *zone_alloc = entry->allocator;
@@ -315,8 +315,6 @@ static int __mlx4_zone_remove_one_entry(struct mlx4_zone_entry *entry) 
		}

		zone_alloc->mask = mask;

	}



	return 0;

}



void mlx4_zone_allocator_destroy(struct mlx4_zone_allocator *zone_alloc)
@@ -457,7 +455,7 @@ struct mlx4_bitmap *mlx4_zone_get_bitmap(struct mlx4_zone_allocator *zones, u32 
int mlx4_zone_remove_one(struct mlx4_zone_allocator *zones, u32 uid)

{

	struct mlx4_zone_entry *zone;

	int res;

	int res = 0;



	spin_lock(&zones->lock);
@@ -468,7 +466,7 @@ int mlx4_zone_remove_one(struct mlx4_zone_allocator *zones, u32 uid) 
		goto out;

	}



	res = __mlx4_zone_remove_one_entry(zone);

	__mlx4_zone_remove_one_entry(zone);



out:

	spin_unlock(&zones->lock);