Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit e33e60ea authored by Jan Kara's avatar Jan Kara Committed by Theodore Ts'o
Browse files

ext4: print error when argument of inode_readahead_blk is invalid 



If argument of inode_readahead_blk is too big, we just bail out
without printing any error. Fix this since it could confuse users.

Signed-off-by: default avatarJan Kara <jack@suse.cz>
Signed-off-by: default avatar"Theodore Ts'o" <tytso@mit.edu>
parent 5f3633e3

fs/ext4/super.c

+4 −5
Original line number Diff line number Diff line
@@ -1555,11 +1555,10 @@ static int handle_mount_opt(struct super_block *sb, char *opt, int token, 
	} else if (token == Opt_min_batch_time) {

		sbi->s_min_batch_time = arg;

	} else if (token == Opt_inode_readahead_blks) {

		if (arg > (1 << 30))

			return -1;

		if (arg && !is_power_of_2(arg)) {

			ext4_msg(sb, KERN_ERR, "EXT4-fs: inode_readahead_blks"

				 " must be a power of 2");

		if (arg && (arg > (1 << 30) || !is_power_of_2(arg))) {

			ext4_msg(sb, KERN_ERR,

				 "EXT4-fs: inode_readahead_blks must be "

				 "0 or a power of 2 smaller than 2^31");

			return -1;

		}

		sbi->s_inode_readahead_blks = arg;