Commit e2c2fc2c authored Jan 30, 2006 by Vlad Yasevich Committed by David S. Miller Jan 30, 2006

[SCTP]: heartbeats exceed maximum retransmssion limit



The number of HEARTBEAT chunks that an association may transmit is
limited by Association.Max.Retrans count; however, the code allows
us to send one extra heartbeat.

This patch limits the number of heartbeats to the maximum count.

Signed-off-by: Vlad Yasevich <vladislav.yasevich@hp.com>
Signed-off-by: Sridhar Samudrala <sri@us.ibm.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent 81845c21

net/sctp/sm_statefuns.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -884,7 +884,7 @@ sctp_disposition_t sctp_sf_sendbeat_8_3(const struct sctp_endpoint *ep,
		{
		struct sctp_transport transport = (struct sctp_transport ) arg;

		if (asoc->overall_error_count > asoc->max_retrans) {
		if (asoc->overall_error_count >= asoc->max_retrans) {
		/* CMD_ASSOC_FAILED calls CMD_DELETE_TCB. */
		sctp_add_cmd_sf(commands, SCTP_CMD_ASSOC_FAILED,
		SCTP_U32(SCTP_ERROR_NO_ERROR));