Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit e2c26f05 authored by Guenter Roeck's avatar Guenter Roeck
Browse files

hwmon: (jc42) Fix integer overflow when writing hysteresis value 



Subtracting an unsigned long from a signed value causes an overflow with large
values. Use clamp_val() to reduce the number range prior to subtracting it
from the temperature limit.

Signed-off-by: default avatarGuenter Roeck <linux@roeck-us.net>
Reviewed-by: default avatarJean Delvare <jdelvare@suse.de>
parent 3a05633b

drivers/hwmon/jc42.c

+2 −0
Original line number Original line Diff line number Diff line
@@ -312,7 +312,9 @@ static ssize_t set_temp_crit_hyst(struct device *dev, 
	if (kstrtoul(buf, 10, &val) < 0)

	if (kstrtoul(buf, 10, &val) < 0)

		return -EINVAL;

		return -EINVAL;





	val = clamp_val(val, 0, JC42_TEMP_MAX);

	diff = jc42_temp_from_reg(data->temp[t_crit]) - val;

	diff = jc42_temp_from_reg(data->temp[t_crit]) - val;



	hyst = 0;

	hyst = 0;

	if (diff > 0) {

	if (diff > 0) {

		if (diff < 2250)

		if (diff < 2250)