Commit e1770d97 authored Jan 28, 2008 by Paul Moore Committed by David S. Miller Jan 31, 2008

[SELinux]: Fix double free in selinux_netlbl_sock_setsid()



As pointed out by Adrian Bunk, commit
45c950e0 ("fix memory leak in netlabel
code") caused a double-free when security_netlbl_sid_to_secattr()
fails.  This patch fixes this by removing the netlbl_secattr_destroy()
call from that function since we are already releasing the secattr
memory in selinux_netlbl_sock_setsid().

Signed-off-by: Paul Moore <paul.moore@hp.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent 1a6509d9

security/selinux/ss/services.c

+0 −1

Original line number	Original line	Diff line number	Diff line
	@@ -2692,7 +2692,6 @@ int security_netlbl_sid_to_secattr(u32 sid, struct netlbl_lsm_secattr *secattr)

	netlbl_sid_to_secattr_failure:		netlbl_sid_to_secattr_failure:
	POLICY_RDUNLOCK;		POLICY_RDUNLOCK;
	netlbl_secattr_destroy(secattr);
	return rc;		return rc;
	}		}
	#endif /* CONFIG_NETLABEL */		#endif /* CONFIG_NETLABEL */