Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit e16f4f3e authored by Benjamin Gaignard's avatar Benjamin Gaignard Committed by Greg Kroah-Hartman
Browse files

base: core: Remove WARN_ON from link dependencies check 

In some cases the link between between customer and supplier
already exist, for example when a device use its parent as a supplier.
Do not warn about already existing dependencies because device_link_add()
takes care of this case.

Link: http://lkml.kernel.org/r/20180709111753eucas1p1f32e66fb2f7ea3216097cd72a132355d~-rzycA5Rg0378203782eucas1p1C@eucas1p1.samsung.com



Reported-by: default avatarMarek Szyprowski <m.szyprowski@samsung.com>
Reviewed-by: default avatarMark Brown <broonie@kernel.org>
Signed-off-by: default avatarBenjamin Gaignard <benjamin.gaignard@st.com>
Reviewed-by: default avatarRafael J. Wysocki <rafael@kernel.org>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 3297c8fc

drivers/base/core.c

+2 −2
Original line number Diff line number Diff line
@@ -105,7 +105,7 @@ static int device_is_dependent(struct device *dev, void *target) 
	struct device_link *link;

	int ret;



	if (WARN_ON(dev == target))

	if (dev == target)

		return 1;



	ret = device_for_each_child(dev, target, device_is_dependent);
@@ -113,7 +113,7 @@ static int device_is_dependent(struct device *dev, void *target) 
		return ret;



	list_for_each_entry(link, &dev->links.consumers, s_node) {

		if (WARN_ON(link->consumer == target))

		if (link->consumer == target)

			return 1;



		ret = device_is_dependent(link->consumer, target);