Commit e13f91e3 authored Nov 05, 2013 by Eric Paris

audit: use memset instead of trying to initialize field by field



We currently are setting fields to 0 to initialize the structure
declared on the stack.  This is a bad idea as if the structure has holes
or unpacked space these will not be initialized.  Just use memset.  This
is not a performance critical section of code.

Signed-off-by: Eric Paris <eparis@redhat.com>

parent 64fbff9a

kernel/audit.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -759,7 +759,7 @@ static int audit_receive_msg(struct sk_buff skb, struct nlmsghdr nlh)

		switch (msg_type) {
		case AUDIT_GET:
		status_set.mask = 0;
		memset(&status_set, 0, sizeof(status_set));
		status_set.enabled = audit_enabled;
		status_set.failure = audit_failure;
		status_set.pid = audit_pid;