Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit e007b857 authored by Eliad Peller's avatar Eliad Peller Committed by John W. Linville
Browse files

nl80211: fix MAC address validation 



MAC addresses have a fixed length. The current
policy allows passing < ETH_ALEN bytes, which
might result in reading beyond the buffer.

Cc: stable@vger.kernel.org
Signed-off-by: default avatarEliad Peller <eliad@wizery.com>
Signed-off-by: default avatarJohn W. Linville <linville@tuxdriver.com>
parent 82e5fc2a

net/wireless/nl80211.c

+2 −2
Original line number Diff line number Diff line
@@ -89,8 +89,8 @@ static const struct nla_policy nl80211_policy[NL80211_ATTR_MAX+1] = { 
	[NL80211_ATTR_IFINDEX] = { .type = NLA_U32 },

	[NL80211_ATTR_IFNAME] = { .type = NLA_NUL_STRING, .len = IFNAMSIZ-1 },



	[NL80211_ATTR_MAC] = { .type = NLA_BINARY, .len = ETH_ALEN },

	[NL80211_ATTR_PREV_BSSID] = { .type = NLA_BINARY, .len = ETH_ALEN },

	[NL80211_ATTR_MAC] = { .len = ETH_ALEN },

	[NL80211_ATTR_PREV_BSSID] = { .len = ETH_ALEN },



	[NL80211_ATTR_KEY] = { .type = NLA_NESTED, },

	[NL80211_ATTR_KEY_DATA] = { .type = NLA_BINARY,