Commit dffb4bb5 authored Sep 14, 2009 by Bjorn Helgaas Committed by Jesse Barnes Sep 14, 2009

PCI hotplug: acpiphp: remove superfluous _HPP/_HPX evaluation



decode_hpp() looks up hotplug PCI parameters from ACPI and saves them
in the acpiphp_bridge structure.  These parameters (in bridge->hpp) are
only used by the acpiphp_set_hpp_values() -> program_hpp() path.  In
that path, we always call decode_hpp() before program_hpp(), so there's
no need to do it in init_bridge_misc().

Signed-off-by: Bjorn Helgaas <bjorn.helgaas@hp.com>
Reviewed-by: Alex Chiang <achiang@hp.com>
Reviewed-by: Kenji Kaneshige <kaneshige.kenji@jp.fujitsu.com>
Acked-by: Kenji Kaneshige <kaneshige.kenji@jp.fujitsu.com>
Signed-off-by: Jesse Barnes <jbarnes@virtuousgeek.org>

parent 4b77b0a2

drivers/pci/hotplug/acpiphp_glue.c

+0 −3

Original line number	Diff line number	Diff line
		@@ -300,9 +300,6 @@ static void init_bridge_misc(struct acpiphp_bridge *bridge)
		{
		acpi_status status;

		/* decode ACPI 2.0 _HPP (hot plug parameters) */
		decode_hpp(bridge);

		/* must be added to the list prior to calling register_slot */
		list_add(&bridge->list, &bridge_list);