Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit df6dd79b authored by Ido Schimmel's avatar Ido Schimmel Committed by David S. Miller
Browse files

mlxsw: spectrum_router: Don't reflect LINKDOWN nexthops 



The kernel resolves the nexthops for a given route using
FIB_LOOKUP_IGNORE_LINKSTATE which means a notification can be sent for a
route with one of its nexthops being LINKDOWN.

In case IGNORE_ROUTES_WITH_LINKDOWN is set for the nexthop netdev, then
we shouldn't reflect the nexthop to the device's table.

Once the nexthop netdev's carrier goes up we'll be notified using NH_ADD
and reflect it to the device.

Signed-off-by: default avatarIdo Schimmel <idosch@mellanox.com>
Signed-off-by: default avatarJiri Pirko <jiri@mellanox.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent d9e1661d

drivers/net/ethernet/mellanox/mlxsw/spectrum_router.c

+10 −1
Original line number Diff line number Diff line
@@ -40,6 +40,7 @@ 
#include <linux/bitops.h>

#include <linux/in6.h>

#include <linux/notifier.h>

#include <linux/inetdevice.h>

#include <net/netevent.h>

#include <net/neighbour.h>

#include <net/arp.h>
@@ -1548,6 +1549,7 @@ static int mlxsw_sp_nexthop_init(struct mlxsw_sp *mlxsw_sp, 
				 struct fib_nh *fib_nh)

{

	struct net_device *dev = fib_nh->nh_dev;

	struct in_device *in_dev;

	struct mlxsw_sp_rif *r;

	int err;
@@ -1557,6 +1559,11 @@ static int mlxsw_sp_nexthop_init(struct mlxsw_sp *mlxsw_sp, 
	if (err)

		return err;



	in_dev = __in_dev_get_rtnl(dev);

	if (in_dev && IN_DEV_IGNORE_ROUTES_WITH_LINKDOWN(in_dev) &&

	    fib_nh->nh_flags & RTNH_F_LINKDOWN)

		return 0;



	r = mlxsw_sp_rif_find_by_dev(mlxsw_sp, dev);

	if (!r)

		return 0;
@@ -1660,8 +1667,10 @@ mlxsw_sp_nexthop_group_create(struct mlxsw_sp *mlxsw_sp, struct fib_info *fi) 


err_nexthop_group_insert:

err_nexthop_init:

	for (i--; i >= 0; i--)

	for (i--; i >= 0; i--) {

		nh = &nh_grp->nexthops[i];

		mlxsw_sp_nexthop_fini(mlxsw_sp, nh);

	}

	kfree(nh_grp);

	return ERR_PTR(err);

}