Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit df550548 authored by Ville Syrjälä's avatar Ville Syrjälä
Browse files

drm: Nuke the useless 'ret' variable from drm_mode_convert_umode() 



No need to store the return value in a variable since we don't have to
do any unwinding.

Signed-off-by: default avatarVille Syrjälä <ville.syrjala@linux.intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20180313150759.27620-1-ville.syrjala@linux.intel.com


Reviewed-by: default avatarDaniel Vetter <daniel.vetter@ffwll.ch>
parent 80343b3e

drivers/gpu/drm/drm_modes.c

+4 −11
Original line number Diff line number Diff line
@@ -1596,12 +1596,8 @@ int drm_mode_convert_umode(struct drm_device *dev, 
			   struct drm_display_mode *out,

			   const struct drm_mode_modeinfo *in)

{

	int ret = -EINVAL;



	if (in->clock > INT_MAX || in->vrefresh > INT_MAX) {

		ret = -ERANGE;

		goto out;

	}

	if (in->clock > INT_MAX || in->vrefresh > INT_MAX)

		return -ERANGE;



	out->clock = in->clock;

	out->hdisplay = in->hdisplay;
@@ -1622,14 +1618,11 @@ int drm_mode_convert_umode(struct drm_device *dev, 


	out->status = drm_mode_validate_driver(dev, out);

	if (out->status != MODE_OK)

		goto out;

		return -EINVAL;



	drm_mode_set_crtcinfo(out, CRTC_INTERLACE_HALVE_V);



	ret = 0;



out:

	return ret;

	return 0;

}



/**