Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit de96e9c5 authored Mar 31, 2016 by James Smart Committed by Martin K. Petersen Apr 11, 2016

lpfc: Correct LOGO handling during login



After a link bounce, when a remote port issues a LOGO while a REGLOGIN
is pending on that port, the driver does not clean up the ndlp
structure. May result in stack traces in the console log.

Fix: Clear the NLP_REG_LOGIN_SEND flag on the ndlp in the routine

Signed-off-by: Dick Kennedy <dick.kennedy@avagotech.com>
Signed-off-by: James Smart <james.smart@avagotech.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>

parent 4c1340af

drivers/scsi/lpfc/lpfc_nportdisc.c

+2 −0

Original line number	Diff line number	Diff line
		@@ -1512,6 +1512,7 @@ lpfc_rcv_logo_reglogin_issue(struct lpfc_vport *vport,
		if ((mb = phba->sli.mbox_active)) {
		if ((mb->u.mb.mbxCommand == MBX_REG_LOGIN64) &&
		(ndlp == (struct lpfc_nodelist *) mb->context2)) {
		ndlp->nlp_flag &= ~NLP_REG_LOGIN_SEND;
		lpfc_nlp_put(ndlp);
		mb->context2 = NULL;
		mb->mbox_cmpl = lpfc_sli_def_mbox_cmpl;
		@@ -1527,6 +1528,7 @@ lpfc_rcv_logo_reglogin_issue(struct lpfc_vport *vport,
		__lpfc_mbuf_free(phba, mp->virt, mp->phys);
		kfree(mp);
		}
		ndlp->nlp_flag &= ~NLP_REG_LOGIN_SEND;
		lpfc_nlp_put(ndlp);
		list_del(&mb->list);
		phba->sli.mboxq_cnt--;

drivers/scsi/lpfc/lpfc_sli.c

+1 −0

Original line number	Diff line number	Diff line
		@@ -2211,6 +2211,7 @@ lpfc_sli_def_mbox_cmpl(struct lpfc_hba phba, LPFC_MBOXQ_t pmb)
		rpi = pmb->u.mb.un.varWords[0];
		vpi = pmb->u.mb.un.varRegLogin.vpi;
		lpfc_unreg_login(phba, vpi, rpi, pmb);
		pmb->vport = vport;
		pmb->mbox_cmpl = lpfc_sli_def_mbox_cmpl;
		rc = lpfc_sli_issue_mbox(phba, pmb, MBX_NOWAIT);
		if (rc != MBX_NOT_FINISHED)