Commit ddfdbccc authored Jun 28, 2019 by Yonglong Liu Committed by Greg Kroah-Hartman Jul 26, 2019

net: hns3: fix a -Wformat-nonliteral compile warning



[ Upstream commit 18d219b783da61a6cc77581f55fc4af2fa16bc36 ]

When setting -Wformat=2, there is a compiler warning like this:

hclge_main.c:xxx:x: warning: format not a string literal and no
format arguments [-Wformat-nonliteral]
strs[i].desc);
^~~~

This patch adds missing format parameter "%s" to snprintf() to
fix it.

Fixes: 46a3df9f ("Add HNS3 Acceleration Engine & Compatibility Layer Support")
Signed-off-by: Yonglong Liu <liuyonglong@huawei.com>
Signed-off-by: Peng Li <lipeng321@huawei.com>
Signed-off-by: Huazhong Tan <tanhuazhong@huawei.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Sasha Levin <sashal@kernel.org>

parent 95d08480

drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_main.c

+1 −2

Original line number	Diff line number	Diff line
		@@ -663,8 +663,7 @@ static u8 *hclge_comm_get_strings(u32 stringset,
		return buff;

		for (i = 0; i < size; i++) {
		snprintf(buff, ETH_GSTRING_LEN,
		strs[i].desc);
		snprintf(buff, ETH_GSTRING_LEN, "%s", strs[i].desc);
		buff = buff + ETH_GSTRING_LEN;
		}