Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit dd0c6e86 authored by John Johansen's avatar John Johansen
Browse files

apparmor: fix capability to not use the current task, during reporting 



Mediation is based off of the cred but auditing includes the current
task which may not be related to the actual request.

Signed-off-by: default avatarJohn Johansen <john.johansen@canonical.com>
parent 50b719f8

security/apparmor/capability.c

+5 −10
Original line number Diff line number Diff line
@@ -53,8 +53,7 @@ static void audit_cb(struct audit_buffer *ab, void *va) 


/**

 * audit_caps - audit a capability

 * @profile: profile confining task (NOT NULL)

 * @task: task capability test was performed against (NOT NULL)

 * @profile: profile being tested for confinement (NOT NULL)

 * @cap: capability tested

 * @error: error code returned by test

 *
@@ -63,8 +62,7 @@ static void audit_cb(struct audit_buffer *ab, void *va) 
 *

 * Returns: 0 or sa->error on success,  error code on failure

 */

static int audit_caps(struct aa_profile *profile, struct task_struct *task,

		      int cap, int error)

static int audit_caps(struct aa_profile *profile, int cap, int error)

{

	struct audit_cache *ent;

	int type = AUDIT_APPARMOR_AUTO;
@@ -73,7 +71,6 @@ static int audit_caps(struct aa_profile *profile, struct task_struct *task, 
	sa.type = LSM_AUDIT_DATA_CAP;

	sa.aad = &aad;

	sa.u.cap = cap;

	sa.aad->tsk = task;

	sa.aad->op = OP_CAPABLE;

	sa.aad->error = error;
@@ -124,8 +121,7 @@ static int profile_capable(struct aa_profile *profile, int cap) 


/**

 * aa_capable - test permission to use capability

 * @task: task doing capability test against (NOT NULL)

 * @profile: profile confining @task (NOT NULL)

 * @profile: profile being tested against (NOT NULL)

 * @cap: capability to be tested

 * @audit: whether an audit record should be generated

 *
@@ -133,8 +129,7 @@ static int profile_capable(struct aa_profile *profile, int cap) 
 *

 * Returns: 0 on success, or else an error code.

 */

int aa_capable(struct task_struct *task, struct aa_profile *profile, int cap,

	       int audit)

int aa_capable(struct aa_profile *profile, int cap, int audit)

{

	int error = profile_capable(profile, cap);
@@ -144,5 +139,5 @@ int aa_capable(struct task_struct *task, struct aa_profile *profile, int cap, 
		return error;

	}



	return audit_caps(profile, task, cap, error);

	return audit_caps(profile, cap, error);

}

security/apparmor/domain.c

+1 −1
Original line number Diff line number Diff line
@@ -75,7 +75,7 @@ static int may_change_ptraced_domain(struct task_struct *task, 
	if (!tracer || unconfined(tracerp))

		goto out;



	error = aa_may_ptrace(tracer, tracerp, to_profile, PTRACE_MODE_ATTACH);

	error = aa_may_ptrace(tracerp, to_profile, PTRACE_MODE_ATTACH);



out:

	rcu_read_unlock();

security/apparmor/include/capability.h

+2 −3
Original line number Diff line number Diff line
@@ -4,7 +4,7 @@ 
 * This file contains AppArmor capability mediation definitions.

 *

 * Copyright (C) 1998-2008 Novell/SUSE

 * Copyright 2009-2010 Canonical Ltd.

 * Copyright 2009-2013 Canonical Ltd.

 *

 * This program is free software; you can redistribute it and/or

 * modify it under the terms of the GNU General Public License as
@@ -38,8 +38,7 @@ struct aa_caps { 


extern struct aa_fs_entry aa_fs_entry_caps[];



int aa_capable(struct task_struct *task, struct aa_profile *profile, int cap,

	       int audit);

int aa_capable(struct aa_profile *profile, int cap, int audit);



static inline void aa_free_cap_rules(struct aa_caps *caps)

{

security/apparmor/include/ipc.h

+2 −2
Original line number Diff line number Diff line
@@ -19,8 +19,8 @@ 


struct aa_profile;



int aa_may_ptrace(struct task_struct *tracer_task, struct aa_profile *tracer,

		  struct aa_profile *tracee, unsigned int mode);

int aa_may_ptrace(struct aa_profile *tracer, struct aa_profile *tracee,

		  unsigned int mode);



int aa_ptrace(struct task_struct *tracer, struct task_struct *tracee,

	      unsigned int mode);

security/apparmor/ipc.c

+4 −5
Original line number Diff line number Diff line
@@ -54,15 +54,14 @@ static int aa_audit_ptrace(struct aa_profile *profile, 


/**

 * aa_may_ptrace - test if tracer task can trace the tracee

 * @tracer_task: task who will do the tracing  (NOT NULL)

 * @tracer: profile of the task doing the tracing  (NOT NULL)

 * @tracee: task to be traced

 * @mode: whether PTRACE_MODE_READ || PTRACE_MODE_ATTACH

 *

 * Returns: %0 else error code if permission denied or error

 */

int aa_may_ptrace(struct task_struct *tracer_task, struct aa_profile *tracer,

		  struct aa_profile *tracee, unsigned int mode)

int aa_may_ptrace(struct aa_profile *tracer, struct aa_profile *tracee,

		  unsigned int mode)

{

	/* TODO: currently only based on capability, not extended ptrace

	 *       rules,
@@ -72,7 +71,7 @@ int aa_may_ptrace(struct task_struct *tracer_task, struct aa_profile *tracer, 
	if (unconfined(tracer) || tracer == tracee)

		return 0;

	/* log this capability request */

	return aa_capable(tracer_task, tracer, CAP_SYS_PTRACE, 1);

	return aa_capable(tracer, CAP_SYS_PTRACE, 1);

}



/**
@@ -101,7 +100,7 @@ int aa_ptrace(struct task_struct *tracer, struct task_struct *tracee, 
	if (!unconfined(tracer_p)) {

		struct aa_profile *tracee_p = aa_get_task_profile(tracee);



		error = aa_may_ptrace(tracer, tracer_p, tracee_p, mode);

		error = aa_may_ptrace(tracer_p, tracee_p, mode);

		error = aa_audit_ptrace(tracer_p, tracee_p, error);



		aa_put_profile(tracee_p);