Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit dd040b6f authored by Matthew Wilcox's avatar Matthew Wilcox Committed by Linus Torvalds
Browse files

radix-tree: fix private list warnings 

The newly introduced warning in radix_tree_free_nodes() was testing the
wrong variable; it should have been 'old' instead of 'node'.

Fixes: ea07b862 ("mm: workingset: fix use-after-free in shadow node shrinker")
Link: http://lkml.kernel.org/r/20170118163746.GA32495@cmpxchg.org


Signed-off-by: default avatarMatthew Wilcox <mawilcox@microsoft.com>
Signed-off-by: default avatarJohannes Weiner <hannes@cmpxchg.org>
Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
parent bbd88e1d

lib/radix-tree.c

+1 −1
Original line number Diff line number Diff line
@@ -769,7 +769,7 @@ static void radix_tree_free_nodes(struct radix_tree_node *node) 
			struct radix_tree_node *old = child;

			offset = child->offset + 1;

			child = child->parent;

			WARN_ON_ONCE(!list_empty(&node->private_list));

			WARN_ON_ONCE(!list_empty(&old->private_list));

			radix_tree_node_free(old);

			if (old == entry_to_node(node))

				return;