Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit dcfcb256 authored by Antti Kaijanmäki's avatar Antti Kaijanmäki Committed by David S. Miller
Browse files

hso: fix soft-lockup 



Fix soft-lockup in hso.c which is triggered on SMP machine when
modem is removed while file descriptor(s) under /dev are still open:

  old version called kref_put() too early which resulted in destroying
  hso_serial and hso_device objects which were still used later on.

Signed-off-by: default avatarAntti Kaijanmäki <antti.kaijanmaki@nomovok.com>
Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 9ce673d5

drivers/net/usb/hso.c

+3 −1
Original line number Diff line number Diff line
@@ -1363,7 +1363,7 @@ static void hso_serial_close(struct tty_struct *tty, struct file *filp) 
	/* reset the rts and dtr */

	/* do the actual close */

	serial->open_count--;

	kref_put(&serial->parent->ref, hso_serial_ref_free);



	if (serial->open_count <= 0) {

		serial->open_count = 0;

		spin_lock_irq(&serial->serial_lock);
@@ -1383,6 +1383,8 @@ static void hso_serial_close(struct tty_struct *tty, struct file *filp) 
		usb_autopm_put_interface(serial->parent->interface);



	mutex_unlock(&serial->parent->mutex);



	kref_put(&serial->parent->ref, hso_serial_ref_free);

}



/* close the requested serial port */