Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit dcd1d830 authored by Colin Ian King's avatar Colin Ian King Committed by Jani Nikula
Browse files

drm/i915/gvt: ensure -ve return value is handled correctly 



An earlier fix changed the return type from find_bb_size however the
integer return is being assigned to a unsigned int so the -ve error
check will never be detected. Make bb_size an int to fix this.

Detected by CoverityScan CID#1456886 ("Unsigned compared against 0")

Fixes: 1e3197d6 ("drm/i915/gvt: Refine error handling for perform_bb_shadow")
Signed-off-by: default avatarColin Ian King <colin.king@canonical.com>
Signed-off-by: default avatarZhenyu Wang <zhenyuw@linux.intel.com>
(cherry picked from commit 24f8a29a)
Signed-off-by: default avatarJani Nikula <jani.nikula@intel.com>
parent 294cf1af

drivers/gpu/drm/i915/gvt/cmd_parser.c

+1 −1
Original line number Diff line number Diff line
@@ -1628,7 +1628,7 @@ static int perform_bb_shadow(struct parser_exec_state *s) 
	struct intel_shadow_bb_entry *entry_obj;

	struct intel_vgpu *vgpu = s->vgpu;

	unsigned long gma = 0;

	uint32_t bb_size;

	int bb_size;

	void *dst = NULL;

	int ret = 0;