Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit dc97a1a9 authored by David S. Miller's avatar David S. Miller
Browse files

genetlink: A genl_bind() to an out-of-range multicast group should not WARN(). 



Users can request to bind to arbitrary multicast groups, so warning
when the requested group number is out of range is not appropriate.

And with the warning removed, and the 'err' variable properly given
an initial value, we can remove 'found' altogether.

Reported-by: default avatarSedat Dilek <sedat.dilek@gmail.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 023e2cfa

net/netlink/genetlink.c

+1 −6
Original line number Diff line number Diff line
@@ -985,8 +985,7 @@ static struct genl_multicast_group genl_ctrl_groups[] = { 


static int genl_bind(struct net *net, int group)

{

	int i, err;

	bool found = false;

	int i, err = 0;



	down_read(&cb_lock);

	for (i = 0; i < GENL_FAM_TAB_SIZE; i++) {
@@ -1003,16 +1002,12 @@ static int genl_bind(struct net *net, int group) 
					err = f->mcast_bind(net, fam_grp);

				else

					err = 0;

				found = true;

				break;

			}

		}

	}

	up_read(&cb_lock);



	if (WARN_ON(!found))

		err = 0;



	return err;

}