Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit dc89cfcf authored by Markus Elfring's avatar Markus Elfring Committed by Mauro Carvalho Chehab
Browse files

[media] tuners: remove uneeded checks before release_firmware() 



The release_firmware() function tests whether its argument is NULL
and then returns immediately. Thus the test around the call is not needed.

This issue was detected by using the Coccinelle software.

Signed-off-by: default avatarMarkus Elfring <elfring@users.sourceforge.net>
Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@osg.samsung.com>
parent 99d2fae9

drivers/media/tuners/si2157.c

+1 −2
Original line number Diff line number Diff line
@@ -196,7 +196,6 @@ static int si2157_init(struct dvb_frontend *fe) 
	return 0;



err:

	if (fw)

	release_firmware(fw);



	dev_dbg(&s->client->dev, "failed=%d\n", ret);

drivers/media/tuners/xc5000.c

+1 −2
Original line number Diff line number Diff line
@@ -1336,7 +1336,6 @@ static int xc5000_release(struct dvb_frontend *fe) 


	if (priv) {

		cancel_delayed_work(&priv->timer_sleep);

		if (priv->firmware)

		release_firmware(priv->firmware);

		hybrid_tuner_release_state(priv);

	}