Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit dc42715f authored by Lucas Stach's avatar Lucas Stach Committed by Tomi Valkeinen
Browse files

video: of: display_timing: remove two unsafe error messages 



The error message would try to dereference the pointer that
just has been tested to be NULL. As those messages don't
really add any value without the info that the np could
provide, just remove them.

Signed-off-by: default avatarLucas Stach <l.stach@pengutronix.de>
Signed-off-by: default avatarTomi Valkeinen <tomi.valkeinen@ti.com>
parent 34bdb666

drivers/video/of_display_timing.c

+2 −6
Original line number Diff line number Diff line
@@ -115,10 +115,8 @@ int of_get_display_timing(struct device_node *np, const char *name, 
{

	struct device_node *timing_np;



	if (!np) {

		pr_err("%s: no devicenode given\n", of_node_full_name(np));

	if (!np)

		return -EINVAL;

	}



	timing_np = of_get_child_by_name(np, name);

	if (!timing_np) {
@@ -142,10 +140,8 @@ struct display_timings *of_get_display_timings(struct device_node *np) 
	struct device_node *native_mode;

	struct display_timings *disp;



	if (!np) {

		pr_err("%s: no device node given\n", of_node_full_name(np));

	if (!np)

		return NULL;

	}



	timings_np = of_get_child_by_name(np, "display-timings");

	if (!timings_np) {