Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit dc2f7271 authored Jun 06, 2017 by Johan Hovold Committed by Greg Kroah-Hartman Jun 13, 2017

serial: rate limit custom-speed deprecation notice



Contrary to what a comment claimed, the ASYNC_SPD flags and custom
divisor can be set by a non-privileged user so rate limit the
deprecation notice as was intended.

Signed-off-by: Johan Hovold <johan@kernel.org>
Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com>
Reviewed-by: Alan Cox <alan@linux.intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

parent 54ebbfb1

drivers/tty/serial/serial_core.c

+2 −3

Original line number	Diff line number	Diff line
		@@ -954,11 +954,10 @@ static int uart_set_info(struct tty_struct tty, struct tty_port port,
		old_custom_divisor != uport->custom_divisor) {
		/*
		* If they're setting up a custom divisor or speed,
		* instead of clearing it, then bitch about it. No
		* need to rate-limit; it's CAP_SYS_ADMIN only.
		* instead of clearing it, then bitch about it.
		*/
		if (uport->flags & UPF_SPD_MASK) {
		dev_notice(uport->dev,
		dev_notice_ratelimited(uport->dev,
		"%s sets custom speed on %s. This is deprecated.\n",
		current->comm,
		tty_name(port->tty));