Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit db6e8cdf authored by Adrian Hunter's avatar Adrian Hunter Committed by Ulf Hansson
Browse files

mmc: sdhci-pci: Add SDHCI_QUIRK_NO_ENDATTR_IN_NOPDESC to BYT 



SDHCI_QUIRK_NO_ENDATTR_IN_NOPDESC actually causes
standard-compliant behaviour by causing the flagging
of the last DMA transfer descriptor as the end
instead of there being an additional nop descriptor
which is flagged as the end.  Consequently, it is
better to have the quirk.  Add it for BYT.

Signed-off-by: default avatarAdrian Hunter <adrian.hunter@intel.com>
Signed-off-by: default avatarUlf Hansson <ulf.hansson@linaro.org>
parent 467e081d

drivers/mmc/host/sdhci-pci.c

+3 −0
Original line number Original line Diff line number Diff line
@@ -294,11 +294,13 @@ static int byt_sd_probe_slot(struct sdhci_pci_slot *slot) 
static const struct sdhci_pci_fixes sdhci_intel_byt_emmc = {

static const struct sdhci_pci_fixes sdhci_intel_byt_emmc = {

	.allow_runtime_pm = true,

	.allow_runtime_pm = true,

	.probe_slot	= byt_emmc_probe_slot,

	.probe_slot	= byt_emmc_probe_slot,

	.quirks		= SDHCI_QUIRK_NO_ENDATTR_IN_NOPDESC,

	.quirks2	= SDHCI_QUIRK2_PRESET_VALUE_BROKEN |

	.quirks2	= SDHCI_QUIRK2_PRESET_VALUE_BROKEN |

			  SDHCI_QUIRK2_STOP_WITH_TC,

			  SDHCI_QUIRK2_STOP_WITH_TC,

};

};





static const struct sdhci_pci_fixes sdhci_intel_byt_sdio = {

static const struct sdhci_pci_fixes sdhci_intel_byt_sdio = {

	.quirks		= SDHCI_QUIRK_NO_ENDATTR_IN_NOPDESC,

	.quirks2	= SDHCI_QUIRK2_HOST_OFF_CARD_ON |

	.quirks2	= SDHCI_QUIRK2_HOST_OFF_CARD_ON |

			SDHCI_QUIRK2_PRESET_VALUE_BROKEN,

			SDHCI_QUIRK2_PRESET_VALUE_BROKEN,

	.allow_runtime_pm = true,

	.allow_runtime_pm = true,
@@ -306,6 +308,7 @@ static const struct sdhci_pci_fixes sdhci_intel_byt_sdio = { 
};

};





static const struct sdhci_pci_fixes sdhci_intel_byt_sd = {

static const struct sdhci_pci_fixes sdhci_intel_byt_sd = {

	.quirks		= SDHCI_QUIRK_NO_ENDATTR_IN_NOPDESC,

	.quirks2	= SDHCI_QUIRK2_CARD_ON_NEEDS_BUS_ON |

	.quirks2	= SDHCI_QUIRK2_CARD_ON_NEEDS_BUS_ON |

			  SDHCI_QUIRK2_PRESET_VALUE_BROKEN |

			  SDHCI_QUIRK2_PRESET_VALUE_BROKEN |

			  SDHCI_QUIRK2_STOP_WITH_TC,

			  SDHCI_QUIRK2_STOP_WITH_TC,