Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit db187178 authored by Ilpo Järvinen's avatar Ilpo Järvinen Committed by Greg Kroah-Hartman
Browse files

leds: ss4200: Convert PCIBIOS_* return codes to errnos 



commit ce068e83976140badb19c7f1307926b4b562fac4 upstream.

ich7_lpc_probe() uses pci_read_config_dword() that returns PCIBIOS_*
codes. The error handling code assumes incorrectly it's a normal errno
and checks for < 0. The return code is returned from the probe function
as is but probe functions should return normal errnos.

Remove < 0 from the check and convert PCIBIOS_* returns code using
pcibios_err_to_errno() into normal errno before returning it.

Fixes: a328e95b ("leds: LED driver for Intel NAS SS4200 series (v5)")
Cc:  <stable@vger.kernel.org>
Signed-off-by: default avatarIlpo Järvinen <ilpo.jarvinen@linux.intel.com>
Link: https://lore.kernel.org/r/20240527132700.14260-1-ilpo.jarvinen@linux.intel.com


Signed-off-by: default avatarLee Jones <lee@kernel.org>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 98cf9959

drivers/leds/leds-ss4200.c

+5 −2
Original line number Diff line number Diff line
@@ -368,8 +368,10 @@ static int ich7_lpc_probe(struct pci_dev *dev, 


	nas_gpio_pci_dev = dev;

	status = pci_read_config_dword(dev, PMBASE, &g_pm_io_base);

	if (status)

	if (status) {

		status = pcibios_err_to_errno(status);

		goto out;

	}

	g_pm_io_base &= 0x00000ff80;



	status = pci_read_config_dword(dev, GPIO_CTRL, &gc);
@@ -381,8 +383,9 @@ static int ich7_lpc_probe(struct pci_dev *dev, 
	}



	status = pci_read_config_dword(dev, GPIO_BASE, &nas_gpio_io_base);

	if (0 > status) {

	if (status) {

		dev_info(&dev->dev, "Unable to read GPIOBASE.\n");

		status = pcibios_err_to_errno(status);

		goto out;

	}

	dev_dbg(&dev->dev, ": GPIOBASE = 0x%08x\n", nas_gpio_io_base);