Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit db0f4691 authored by Sebastian Reichel's avatar Sebastian Reichel Committed by Mauro Carvalho Chehab
Browse files

[media] v4l: Allow calling v4l2_device_register_subdev_nodes() multiple times 



Previously multiple calls to v4l2_device_register_subdev_nodes() ended up
corrupting memory and leaking some, too. This patch changes the behaviour so
that sub-devices the device nodes of which are already registered are
ignored.

Signed-off-by: default avatarSebastian Reichel <sre@kernel.org>
Signed-off-by: default avatarIvaylo Dimitrov <ivo.g.dimitrov.75@gmail.com>
Signed-off-by: default avatarPavel Machek <pavel@ucw.cz>
Signed-off-by: default avatarSakari Ailus <sakari.ailus@linux.intel.com>
Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@s-opensource.com>
parent 974f4a38

drivers/media/v4l2-core/v4l2-device.c

+3 −0
Original line number Diff line number Diff line
@@ -235,6 +235,9 @@ int v4l2_device_register_subdev_nodes(struct v4l2_device *v4l2_dev) 
		if (!(sd->flags & V4L2_SUBDEV_FL_HAS_DEVNODE))

			continue;



		if (sd->devnode)

			continue;



		vdev = kzalloc(sizeof(*vdev), GFP_KERNEL);

		if (!vdev) {

			err = -ENOMEM;