Commit dae82d9d authored Oct 19, 2017 by Akinobu Mita Committed by Mauro Carvalho Chehab Oct 31, 2017

media: ov5640: don't clear V4L2_SUBDEV_FL_IS_I2C



The v4l2_i2c_subdev_init() sets V4L2_SUBDEV_FL_IS_I2C flag in the
subdev->flags.  But this driver overwrites subdev->flags immediately after
calling v4l2_i2c_subdev_init().  So V4L2_SUBDEV_FL_IS_I2C is not set after
all.

This stops breaking subdev->flags and preserves V4L2_SUBDEV_FL_IS_I2C.

Side note: According to the comment in v4l2_device_unregister(), this is
problematic only if the device is platform bus device.  Device tree or
ACPI based devices are not affected.

Cc: Mauro Carvalho Chehab <mchehab@s-opensource.com>
Signed-off-by: Akinobu Mita <akinobu.mita@gmail.com>
Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@s-opensource.com>

parent 6b725eb6

drivers/media/i2c/ov5640.c

+1 −1

Original line number	Original line	Diff line number	Diff line
	@@ -2271,7 +2271,7 @@ static int ov5640_probe(struct i2c_client *client,

	v4l2_i2c_subdev_init(&sensor->sd, client, &ov5640_subdev_ops);		v4l2_i2c_subdev_init(&sensor->sd, client, &ov5640_subdev_ops);

	sensor->sd.flags = V4L2_SUBDEV_FL_HAS_DEVNODE;		sensor->sd.flags \|= V4L2_SUBDEV_FL_HAS_DEVNODE;
	sensor->pad.flags = MEDIA_PAD_FL_SOURCE;		sensor->pad.flags = MEDIA_PAD_FL_SOURCE;
	sensor->sd.entity.function = MEDIA_ENT_F_CAM_SENSOR;		sensor->sd.entity.function = MEDIA_ENT_F_CAM_SENSOR;
	ret = media_entity_pads_init(&sensor->sd.entity, 1, &sensor->pad);		ret = media_entity_pads_init(&sensor->sd.entity, 1, &sensor->pad);