Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit da2f3b28 authored by Zhu Yanjun's avatar Zhu Yanjun Committed by Jason Gunthorpe
Browse files

IB/rxe: avoid calling WARN_ON_ONCE twice 



In the exit branch, WARN_ON_ONCE is called to show stack. So it is
not necessary to call WARN_ON_ONCE before going to exit.

Signed-off-by: default avatarZhu Yanjun <yanjun.zhu@oracle.com>
Reviewed-by: default avatarLeon Romanovsky <leonro@mellanox.com>
Signed-off-by: default avatarJason Gunthorpe <jgg@mellanox.com>
parent 5e6e78db

drivers/infiniband/sw/rxe/rxe_comp.c

+0 −4
Original line number Diff line number Diff line
@@ -659,7 +659,6 @@ int rxe_completer(void *arg) 
			    qp->qp_timeout_jiffies)

				mod_timer(&qp->retrans_timer,

					  jiffies + qp->qp_timeout_jiffies);

			WARN_ON_ONCE(skb);

			goto exit;



		case COMPST_ERROR_RETRY:
@@ -673,7 +672,6 @@ int rxe_completer(void *arg) 


			/* there is nothing to retry in this case */

			if (!wqe || (wqe->state == wqe_state_posted)) {

				WARN_ON_ONCE(skb);

				goto exit;

			}
@@ -702,7 +700,6 @@ int rxe_completer(void *arg) 
					skb = NULL;

				}



				WARN_ON_ONCE(skb);

				goto exit;



			} else {
@@ -746,7 +743,6 @@ int rxe_completer(void *arg) 
				skb = NULL;

			}



			WARN_ON_ONCE(skb);

			goto exit;

		}

	}