Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit d9bb03dc authored by Greg Kroah-Hartman's avatar Greg Kroah-Hartman
Browse files

USB: serial: io_ti: remove some remaining printk() calls 



Use dev_err() like the rest of that function does, and the rest of the
driver does, to properly show what device and driver caused the problem.

Cc: Johan Hovold <jhovold@gmail.com>
Cc: "Eric W. Biederman" <ebiederm@xmission.com>
Cc: Rusty Russell <rusty@rustcorp.com.au>
Cc: Alan Stern <stern@rowland.harvard.edu>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 1a71bd2e

drivers/usb/serial/io_ti.c

+4 −4
Original line number Original line Diff line number Diff line
@@ -845,7 +845,7 @@ static int build_i2c_fw_hdr(__u8 *header, struct device *dev) 




	err = request_firmware(&fw, fw_name, dev);

	err = request_firmware(&fw, fw_name, dev);

	if (err) {

	if (err) {

		printk(KERN_ERR "Failed to load image \"%s\" err %d\n",

		dev_err(dev, "Failed to load image \"%s\" err %d\n",

			fw_name, err);

			fw_name, err);

		kfree(buffer);

		kfree(buffer);

		return err;

		return err;
@@ -1404,7 +1404,7 @@ static int download_fw(struct edgeport_serial *serial) 




		err = request_firmware(&fw, fw_name, dev);

		err = request_firmware(&fw, fw_name, dev);

		if (err) {

		if (err) {

			printk(KERN_ERR "Failed to load image \"%s\" err %d\n",

			dev_err(dev, "Failed to load image \"%s\" err %d\n",

				fw_name, err);

				fw_name, err);

			kfree(buffer);

			kfree(buffer);

			return err;

			return err;