Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit d90c3381 authored by David Cohen's avatar David Cohen Committed by Linus Walleij
Browse files

pinctrl: baytrail: show output gpio state correctly on Intel Baytrail 



Even if a gpio pin is set to output, we still need to set INPUT_EN
functionality (by clearing INPUT_EN bit) to be able to read the pin's
level.

E.g. without this change, we'll always read low level state from sysfs.

Cc: <stable@vger.kernel.org> # v3.14+
Cc: Mathias Nyman <mathias.nyman@linux.intel.com>
Signed-off-by: default avatarDavid Cohen <david.a.cohen@linux.intel.com>
Reviewed-by: default avatarFelipe Balbi <balbi@ti.com>
Signed-off-by: default avatarLinus Walleij <linus.walleij@linaro.org>
parent c11f042b

drivers/pinctrl/pinctrl-baytrail.c

+1 −1
Original line number Diff line number Diff line
@@ -322,7 +322,7 @@ static int byt_gpio_direction_output(struct gpio_chip *chip, 
		"Potential Error: Setting GPIO with direct_irq_en to output");



	reg_val = readl(reg) | BYT_DIR_MASK;

	reg_val &= ~BYT_OUTPUT_EN;

	reg_val &= ~(BYT_OUTPUT_EN | BYT_INPUT_EN);



	if (value)

		writel(reg_val | BYT_LEVEL, reg);