Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit d8a2cf41 authored by Javier Martinez Canillas's avatar Javier Martinez Canillas Committed by Mauro Carvalho Chehab
Browse files

[media] v4l: vsp1: remove pads prefix from *_create_pads_links() 



The functions that create entities links are called *_create_pads_links()
but the "pads" prefix is redundant since the driver doesn't handle any
other kind of link so it can be removed.

Suggested-by: default avatarLaurent Pinchart <laurent.pinchart@ideasonboard.com>
Signed-off-by: default avatarJavier Martinez Canillas <javier@osg.samsung.com>
Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@osg.samsung.com>
parent 04e02151

drivers/media/platform/vsp1/vsp1_drv.c

+2 −2
Original line number Diff line number Diff line
@@ -261,14 +261,14 @@ static int vsp1_create_entities(struct vsp1_device *vsp1) 
	/* Create links. */

	list_for_each_entry(entity, &vsp1->entities, list_dev) {

		if (entity->type == VSP1_ENTITY_LIF) {

			ret = vsp1_wpf_create_pads_links(vsp1, entity);

			ret = vsp1_wpf_create_links(vsp1, entity);

			if (ret < 0)

				goto done;

			continue;

		}



		if (entity->type == VSP1_ENTITY_RPF) {

			ret = vsp1_rpf_create_pads_links(vsp1, entity);

			ret = vsp1_rpf_create_links(vsp1, entity);

			if (ret < 0)

				goto done;

			continue;

drivers/media/platform/vsp1/vsp1_rpf.c

+2 −2
Original line number Diff line number Diff line
@@ -285,13 +285,13 @@ struct vsp1_rwpf *vsp1_rpf_create(struct vsp1_device *vsp1, unsigned int index) 
}



/*

 * vsp1_rpf_create_pads_links_create_pads_links() - RPF pads links creation

 * vsp1_rpf_create_links() - RPF pads links creation

 * @vsp1: Pointer to VSP1 device

 * @entity: Pointer to VSP1 entity

 *

 * return negative error code or zero on success

 */

int vsp1_rpf_create_pads_links(struct vsp1_device *vsp1,

int vsp1_rpf_create_links(struct vsp1_device *vsp1,

			       struct vsp1_entity *entity)

{

	struct vsp1_rwpf *rpf = to_rwpf(&entity->subdev);

drivers/media/platform/vsp1/vsp1_rwpf.h

+2 −2
Original line number Diff line number Diff line
@@ -50,9 +50,9 @@ static inline struct vsp1_rwpf *to_rwpf(struct v4l2_subdev *subdev) 
struct vsp1_rwpf *vsp1_rpf_create(struct vsp1_device *vsp1, unsigned int index);

struct vsp1_rwpf *vsp1_wpf_create(struct vsp1_device *vsp1, unsigned int index);



int vsp1_rpf_create_pads_links(struct vsp1_device *vsp1,

int vsp1_rpf_create_links(struct vsp1_device *vsp1,

			       struct vsp1_entity *entity);

int vsp1_wpf_create_pads_links(struct vsp1_device *vsp1,

int vsp1_wpf_create_links(struct vsp1_device *vsp1,

			       struct vsp1_entity *entity);



int vsp1_rwpf_enum_mbus_code(struct v4l2_subdev *subdev,

drivers/media/platform/vsp1/vsp1_wpf.c

+2 −2
Original line number Diff line number Diff line
@@ -285,13 +285,13 @@ struct vsp1_rwpf *vsp1_wpf_create(struct vsp1_device *vsp1, unsigned int index) 
}



/*

 * vsp1_wpf_create_pads_links_create_pads_links() - RPF pads links creation

 * vsp1_wpf_create_links() - RPF pads links creation

 * @vsp1: Pointer to VSP1 device

 * @entity: Pointer to VSP1 entity

 *

 * return negative error code or zero on success

 */

int vsp1_wpf_create_pads_links(struct vsp1_device *vsp1,

int vsp1_wpf_create_links(struct vsp1_device *vsp1,

			       struct vsp1_entity *entity)

{

	struct vsp1_rwpf *wpf = to_rwpf(&entity->subdev);