Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit d89293ab authored by Tejun Heo's avatar Tejun Heo Committed by Jeff Garzik
Browse files

libata: fix EH device failure handling 



The dev->pio_mode > XFER_PIO_0 test is there to avoid unnecessary
speed down warning messages but it accidentally disabled SATA link spd
down during configuration phase after reset where PIO mode is always
zero.

This patch fixes the problem by moving the test where it belongs.
This makes libata probing sequence behave better when the connection
is flaky at higher link speeds which isn't too uncommon for eSATA
devices.

Signed-off-by: default avatarTejun Heo <tj@kernel.org>
Signed-off-by: default avatarJeff Garzik <jgarzik@redhat.com>
parent 8d993eaa

drivers/ata/libata-eh.c

+3 −2
Original line number Diff line number Diff line
@@ -2979,11 +2979,12 @@ static int ata_eh_handle_dev_fail(struct ata_device *dev, int err) 
		/* give it just one more chance */

		ehc->tries[dev->devno] = min(ehc->tries[dev->devno], 1);

	case -EIO:

		if (ehc->tries[dev->devno] == 1 && dev->pio_mode > XFER_PIO_0) {

		if (ehc->tries[dev->devno] == 1) {

			/* This is the last chance, better to slow

			 * down than lose it.

			 */

			sata_down_spd_limit(ata_dev_phys_link(dev));

			if (dev->pio_mode > XFER_PIO_0)

				ata_down_xfermask_limit(dev, ATA_DNXFER_PIO);

		}

	}